Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log analyzer #744

Merged
merged 7 commits into from Nov 12, 2023
Merged

feat: log analyzer #744

merged 7 commits into from Nov 12, 2023

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Nov 12, 2023 •
edited

This has been intentionally added as an opt-in analzyer

📑 Description

✅ Checks

  • [ x] My pull request adheres to the code style of this project
  • [ x] My code requires changes to the documentation
  • [ x] I have updated the documentation as required
  • [ x] All the tests have passed

ℹ Additional Information

@AlexsJones
feat: wip log analyzer
ddbf2cd 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
chore: turns off log by default
dde4344 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones requested review from a team as code owners November 12, 2023 01:11
thschue
thschue requested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid first implementation to me! Tested this and it works. As discussed we should add some warning when enabling the integration that sensitive information might not be filtered before it is submitted to the LLM.

@AlexsJones
chore: turns off log by default
017c7f4 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
thschue
thschue approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexsJones AlexsJones merged commit d365886 into main Nov 12, 2023
7 checks passed
@AlexsJones AlexsJones deleted the feat/logs branch November 12, 2023 21:00
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexsJones @thschue