-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.8] Skip pods in critical namespaces #107
[release-v0.8] Skip pods in critical namespaces #107
Conversation
/release-note-none |
58de9a6
to
5ac0f74
Compare
This PR fix the issue when a Critical pod like the sdn provider need to be recreated. change the mutating webhook to skip namespaces to contains 1. runlevel=[0,1] for kubernetes environments 2. openshift.io/run-level=[0,1] for openshift environments With this change we can change the FailurePolicy from ignore to fail. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Petr Horacek <phoracek@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just a small nit
Signed-off-by: Petr Horacek <phoracek@redhat.com>
/lgtm |
/override pull-kubemacpool-e2e-k8s These lanes are not available on release-v0.8. This passed |
@phoracek: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Petr Horacek <phoracek@redhat.com>
@phoracek: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override pull-kubemacpool-e2e-k8s These lanes are not available on release-v0.8. |
@phoracek: Overrode contexts on behalf of phoracek: pull-kubemacpool-e2e-k8s, pull-kubemacpool-unit-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: phoracek, RamLavi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fix the issue when a Critical pod like the sdn provider
need to be recreated.
change the mutating webhook to skip namespaces to contains
With this change we can change the FailurePolicy from ignore to fail.
Signed-off-by: Sebastian Sch sebassch@gmail.com