Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.8] Skip pods in critical namespaces #107

Merged

Conversation

phoracek
Copy link
Member

This PR fix the issue when a Critical pod like the sdn provider
need to be recreated.

change the mutating webhook to skip namespaces to contains

  1. runlevel=[0,1] for kubernetes environments
  2. openshift.io/run-level=[0,1] for openshift environments

With this change we can change the FailurePolicy from ignore to fail.

Signed-off-by: Sebastian Sch sebassch@gmail.com

@phoracek
Copy link
Member Author

/release-note-none

This PR fix the issue when a Critical pod like the sdn provider
need to be recreated.

change the mutating webhook to skip namespaces to contains

1. runlevel=[0,1] for kubernetes environments
2. openshift.io/run-level=[0,1] for openshift environments

With this change we can change the FailurePolicy from ignore to fail.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
config/default/manager/manager.yaml Show resolved Hide resolved
tests/tests.go Show resolved Hide resolved
Signed-off-by: Petr Horacek <phoracek@redhat.com>
tests/pods_test.go Show resolved Hide resolved
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just a small nit

tests/pods_test.go Outdated Show resolved Hide resolved
Signed-off-by: Petr Horacek <phoracek@redhat.com>
@RamLavi
Copy link
Member

RamLavi commented Mar 12, 2020

/lgtm

@phoracek
Copy link
Member Author

/override pull-kubemacpool-e2e-k8s
/override pull-kubemacpool-unit-test
/hold

These lanes are not available on release-v0.8.

This passed make functest on kubevirtci cluster for me locally except for a single test should fail to create a pod on a regular namespace when mac pool is down the same issue happens on Travis.

@kubevirt-bot
Copy link
Collaborator

@phoracek: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • pull-kubemacpool-e2e-k8s

Only the following contexts were expected:

  • continuous-integration/travis-ci/pr
  • pull-kubemacpool-e2e-k8s
  • pull-kubemacpool-unit-test
  • tide

In response to this:

/override pull-kubemacpool-e2e-k8s
/override pull-kubemacpool-unit-test
/hold

These lanes are not available on release-v0.8.

This passed make functest on kubevirtci cluster for me locally except for a single test should fail to create a pod on a regular namespace when mac pool is down the same issue happens on Travis.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phoracek phoracek changed the title Skip pods in critical namespaces [release-v0.8] Skip pods in critical namespaces Mar 12, 2020
@kubevirt-bot kubevirt-bot removed the lgtm label Mar 12, 2020
Signed-off-by: Petr Horacek <phoracek@redhat.com>
@kubevirt-bot
Copy link
Collaborator

@phoracek: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubemacpool-unit-test e6b9327 link /test pull-kubemacpool-unit-test
pull-kubemacpool-e2e-k8s e6b9327 link /test pull-kubemacpool-e2e-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@phoracek
Copy link
Member Author

/override pull-kubemacpool-e2e-k8s
/override pull-kubemacpool-unit-test
/hold

These lanes are not available on release-v0.8.

@kubevirt-bot
Copy link
Collaborator

@phoracek: Overrode contexts on behalf of phoracek: pull-kubemacpool-e2e-k8s, pull-kubemacpool-unit-test

In response to this:

/override pull-kubemacpool-e2e-k8s
/override pull-kubemacpool-unit-test
/hold

These lanes are not available on release-v0.8.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RamLavi
Copy link
Member

RamLavi commented Mar 12, 2020

/lgtm
/approve

@phoracek
Copy link
Member Author

/hold cancel

@phoracek
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: phoracek, RamLavi
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@phoracek phoracek merged commit b3b7bde into k8snetworkplumbingwg:release-v0.8 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants