[Release v0.14.0] change leadership mechanism #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected leader pod This also means we get can remove the use of leaderElectionChannel Signed-off-by: Ram Lavi <ralavi@redhat.com>
…er() Signed-off-by: Ram Lavi <ralavi@redhat.com>
in thie commit we move waitToStartLeading() to a separate go routine, so that both pods will start the controller-runtime manager. we then add the leader election inside the controller runtime manager. Signed-off-by: Ram Lavi <ralavi@redhat.com>
since the webhook service operates only on pods with kubemacpool leader label, we cant start the webhooks until the election is complete and a leader as been chosen. in order to do that, we add a new status to the pod, to prevent the pods to be ready and the webhhoks to start until the label is set. Signed-off-by: Ram Lavi <ralavi@redhat.com>
…appropriate rbacs. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
…y will initiate after teh election is complete since we don't want both pods to perform pool-manager related operations, we start the pool-manager routines only after the kubemacpool leader is selected. Signed-off-by: Ram Lavi <ralavi@redhat.com>
…oyment replicas, as well as making the needed changes in test to wait for both kubemacpool instead of only to the leader. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RamLavi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
manual cherry pick of #182
Special notes for your reviewer:
Release note: