[release-v0.14.0] bump kubevirt to v0.34.2 #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kubevirt currently used doesn't support disk.io support, which causes it to be removed from the vm instance when reconciled by kubemacpool. Bumped to v0.34.2 to support disk.io in the vm object Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
phoracek
reviewed
Nov 27, 2020
| @@ -25,7 +25,7 @@ source ./cluster/kubevirtci.sh | |||
| CNAO_VERSIOV=0.35.0 | |||
| #use kubevirt latest z stream release | |||
|
|
|||
| KUBEVIRT_VERSION=$(getLatestPatchVersion v0.30) | |||
| KUBEVIRT_VERSION=$(getLatestPatchVersion v0.34) | |||
There was a problem hiding this comment.
The bug https://bugzilla.redhat.com/show_bug.cgi?id=1901480 is for 2.6 which is yet to be branched out. This fix should be on the master.
In case we decide to fix the bug in a 2.5 z-stream, we would then needs a change similar to this (but I believe we should pin to v0.30.7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps kubevirt to v0.34.2 on the stable branch, to support disk.io configuration.
What this PR does / why we need it:
Special notes for your reviewer:
Release note: