tools, Makefile: Don't use vendor for tools #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamLavi
force-pushed
the
remove_tools
branch
from
10f462e
to
be5ed15
Compare
|
/test pull-kubemacpool-e2e-k8s |
The vendor directory should concern only the product, tools cannot pollute it. Signed-off-by: Ram Lavi <ralavi@redhat.com>
Due to running kustomize in a new version, the manifests change in generation order, but not in value. Since these files are generated, commiting change. Signed-off-by: Ram Lavi <ralavi@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the
make toolstarget that installs the binaries locally on the go folder. This method pollutes the vendor folder, and so we move to usego runwith the new API supported on go 1.17 release notesSpecial notes for your reviewer:
Release note: