Bump ginkgo v2 #382
Merged
Bump ginkgo v2 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if CI goes smoothly, I'll try to reintroduce the custom reporters and junit-output arg |
|
/retest |
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
After bumping ginkgo to v2, adding relevant test flags: ginkgo.timeout, test.outputdir, ginkgo.junit-report Signed-off-by: Ram Lavi <ralavi@redhat.com>
RamLavi
force-pushed
the
bump_ginkgo_v2_try2
branch
from
8b55785
to
7fe9f66
Compare
|
@qinqon looks like we have artifacts folder with the junit file |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR bumps kubemacpool to ginkgo v2
Special notes for your reviewer:
Release note: