rbac: Minimize rbacs #387
Merged
rbac: Minimize rbacs #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshoval
force-pushed
the
rbac
branch
4 times, most recently
from
e461f90
to
bef6f3a
Compare
As part of the effort to minimize CNAO's and its componenets required rbacs, minimize the KubeMacPool rbacs, according the ones that are needed for deployment and e2e tests. Signed-off-by: Or Shoval <oshoval@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As part of the effort to minimize CNAO's and its componenets
required rbacs, minimize the KubeMacPool rbacs, according the ones
that are needed for deployment and e2e tests.
Special notes for your reviewer:
More improvements will be done on 2nd phase.
This PR focus is to eliminate the wildcards that are used.
Release note: