Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaw: Bump go to 1.19 and replace webhook server #393

Merged

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Sep 12, 2023

What this PR does / why we need it:
Latest kaw remove the unmaintained custom webhook server and bump controller-runtime to pass cipher suite propertly. This change bump dependencies and adapt kubemacpool tls config to the proper way of doing it.

Release note:

Remove kaw webhook server and use controller-runtime one to pass TLS config

Latest kaw remove the unmaintained custom webhook server and bump
controller-runtime to pass cipher suite propertly. This change bump
dependencies and adapt kubemacpool tls config to the proper way of doing
it.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Copy link
Member

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 5ebb3d9 into k8snetworkplumbingwg:main Sep 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants