Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check hashicorp: Add hashicorp whitelist #394

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Sep 27, 2023

What this PR does / why we need it:
Validates that no hashicorp are used beside the whitelisted ones
(because they shifted to BSL license)

Special notes for your reviewer:
Atm no hashicorp is used, but lets protect in case someone will add.
Based on the whitelist that CNAO uses.

Need to validate git actions runs it on next PRs, as this is the first one.
(git actions is enabled)

Release note:

None

Signed-off-by: Or Shoval <oshoval@redhat.com>
Copy link
Member

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit d993bcc into k8snetworkplumbingwg:main Sep 27, 2023
4 checks passed
@oshoval
Copy link
Member Author

oshoval commented Sep 27, 2023

It seems git actions isnt configured correctly, as it had to run it already even before it is merged
if you can take a look please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants