Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update golang.org/x/* modules and rework tests #398

Merged
merged 2 commits into from
Oct 30, 2023
Merged

chore: Update golang.org/x/* modules and rework tests #398

merged 2 commits into from
Oct 30, 2023

Conversation

0xFelix
Copy link
Contributor

@0xFelix 0xFelix commented Oct 26, 2023

What this PR does / why we need it:

Updated modules golang.org/x/* to the latest versions.

To allow go mod tidy to work again the dependency on kubevirt.io/kubevirt
and the broken replacement of gopkg.in/k8snetworkplumbingwg/multus-cni.v3 are
removed.

Special notes for your reviewer:

Release note:

None

@kubevirt-bot
Copy link
Collaborator

Hi @0xFelix. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xFelix
tests: Remove dependency on kubevirt.io/kubevirt
6634df8 
This removes the dependency on kubevirt.io/kubevirt and removes the
broken replacement of gopkg.in/k8snetworkplumbingwg/multus-cni.v3.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@0xFelix 0xFelix mentioned this pull request Oct 26, 2023
Closed
@0xFelix
chore: Update golang.org/x/* modules
2331d21 
Updated modules golang.org/x/* to the latest versions.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@mhenriks
Copy link

/lgtm

@kubevirt-bot
Copy link
Collaborator

@mhenriks: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oshoval
Copy link
Member

oshoval commented Oct 29, 2023

Very nice thanks
/lgtm

@RamLavi
Copy link
Member

RamLavi commented Oct 30, 2023

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 94abfea into k8snetworkplumbingwg:main Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@RamLavi RamLavi Awaiting requested review from RamLavi

Assignees

@oshoval oshoval

Labels
approved dco-signoff: yes lgtm needs-ok-to-test release-note-none size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0xFelix @kubevirt-bot @mhenriks @oshoval @RamLavi