Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kube-rbac-proxy #404

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Oct 31, 2023

What this PR does / why we need it:
Includes openshift/kube-rbac-proxy#80

Special notes for your reviewer:

Release note:

None

@oshoval
Copy link
Member Author

oshoval commented Nov 2, 2023

/cc @RamLavi

@@ -138,7 +138,7 @@ spec:
capabilities:
drop:
- ALL
image: quay.io/openshift/origin-kube-rbac-proxy:4.10.0
image: quay.io/openshift/origin-kube-rbac-proxy:4.15.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want hash or version
hash is static but might be deleted (we are using hash on CNAO fwiw)
version is dynamic, not deleted by might present flakes.

@RamLavi
Copy link
Member

RamLavi commented Nov 12, 2023

Can you please update the commit desc? Or is it a WIP PR that is only meant to confirm CNAO?

Includes openshift/kube-rbac-proxy#80

Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval oshoval force-pushed the bumpkrp branch 2 times, most recently from fe25e40 to d71cbc9 Compare November 12, 2023 10:30
@oshoval
Copy link
Member Author

oshoval commented Nov 12, 2023

Done, not a WIP anymore, just forgot to update
it is not dependent on CNAO, and not vice versa
CNAO just replace whatever it is to what CNAO wants

@oshoval
Copy link
Member Author

oshoval commented Nov 12, 2023

Interesting here
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_kubemacpool/404/pull-kubemacpool-e2e-k8s/1723649479040569344

I dont think it is related to the PR
kube-rbac-proxy is a side car container that listens to the http metrics port and convert it to https,
protected by rbac

btw few days ago there was also this one (on other PR) in this area more or less

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1678/pull-e2e-cnao-kubemacpool-functests-release-0.89/1721495335496323072

If you want i can open issue for those 2

@oshoval
Copy link
Member Author

oshoval commented Nov 30, 2023

/retest

not related to this PR imo

@qinqon
Copy link
Member

qinqon commented Dec 4, 2023

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit ad90843 into k8snetworkplumbingwg:main Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants