Infer PolicyTypes if missing #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5529027813
💛 - Coveralls |
s1061123
requested changes
Jun 30, 2023
pkg/server/server.go
Outdated
| } | ||
| } | ||
| } | ||
| var ingressEnable, egressEnable bool = getEnabledPolicyTypes(policy) |
There was a problem hiding this comment.
how about to change that? (it is just for shorten code with same meaning, so not critical)
ingressEnable, egressEnable := getEnabledPolicyTypes(policy)
Merged
|
|
|
@zeeke Appreciated your e2e test fix! Could you please rebase the PR to get the e2e fix? |
|
@zeeke I update the PR but e2e still failed. PTAL? |
|
Sure, I'll have a look |
In cases where Spec.PolicyTypes is not specified, it should default to the existence of Ingress or Egress rules. Updating end2end tests to cover also this scenario. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
|
Some tests were missing a sleep after the test setup. I think some assertions were running before the server policy sync. |
|
@zeeke thank you for the quick fix! Let's merge that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where Spec.PolicyTypes is not specified, it should default to the existence of Ingress or Egress rules.
Updating end2end tests to cover also this scenario.
Changes have been guided by the regular NetworkPolicy documentation: