Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #53

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

almaslennikov
Copy link
Contributor

Update go to 1.20
Update golangci-lint
Update github actions (static checks, arm64 build)

@coveralls
Copy link
Collaborator

coveralls commented Jul 11, 2023

Pull Request Test Coverage Report for Build 5516645916

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 79.716%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/pod.go 1 2 50.0%
Totals Coverage Status
Change from base Build 4540394472: 0.007%
Covered Lines: 2244
Relevant Lines: 2815

💛 - Coveralls

@almaslennikov almaslennikov force-pushed the housekeeping branch 3 times, most recently from 02c01e4 to 3fa911d Compare July 14, 2023 09:01
Copy link

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/controllers/controller_suite_test.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
.github/workflows/static-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/push-release.yml Outdated Show resolved Hide resolved
@almaslennikov almaslennikov force-pushed the housekeeping branch 4 times, most recently from 8ea6c6c to a2067df Compare July 19, 2023 09:19
@almaslennikov
Copy link
Contributor Author

@ykulazhenkov we need to allow github CI actions write access, otherwise hadolint check won't run

@ykulazhenkov
Copy link
Collaborator

ykulazhenkov commented Jul 19, 2023

@ykulazhenkov we need to allow github CI actions write access, otherwise hadolint check won't run

@almaslennikov

current CI issue is not related to actions permissions

Downloading https://github.com/hadolint/hadolint/releases/download/v2.12.1-beta/hadolint-Linux-x86_64
/hadolint: Permission denied
make: *** [Makefile:81: /hadolint] Error 1
Error: Process completed with exit code 2.

You have bug in the Makefile HADOLINT_TOOL = $(BINDIR)/hadolint should be HADOLINT_TOOL = $(BIN_DIR)/hadolint

@ykulazhenkov ykulazhenkov self-requested a review July 19, 2023 12:06
@@ -76,6 +76,14 @@ unit-test: envtest ## Run unit tests.
.PHONY: test
test: lint unit-test ## Run all tests (lint, unit-test).

HADOLINT_TOOL = $(BINDIR)/hadolint
$(HADOLINT_TOOL): | $(BASE) ; $(info installing hadolint...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this repo directory for bin files is in BIN_DIR var not in BINDIR

Update golangci-lint and fix lint and test problems

Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
@ykulazhenkov ykulazhenkov merged commit 1bdd521 into k8snetworkplumbingwg:main Jul 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants