Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logFile documentation in README #177

Closed
mccv1r0 opened this issue Oct 30, 2018 · 0 comments
Closed

Fix logFile documentation in README #177

mccv1r0 opened this issue Oct 30, 2018 · 0 comments

Comments

@mccv1r0
Copy link
Contributor

mccv1r0 commented Oct 30, 2018

The text in Logging Options refers to LogFile, which should be logFile to match json
mccv1r0 added a commit to mccv1r0/multus-cni that referenced this issue Oct 30, 2018
@mccv1r0
Fix logFile to match configuration json
641b635 
The Logging Options section of README describes how to specify a file
to log to.  There is a typo, LogFile should be logFile to match the
json.

Fixes k8snetworkplumbingwg#177

Signed-off-by: Michael Cambria <mcambria@redhat.com>
@mccv1r0 mccv1r0 mentioned this issue Oct 30, 2018
Merged
rkamudhan pushed a commit that referenced this issue Oct 31, 2018
@mccv1r0 @rkamudhan
Fix logFile to match configuration json
5eca507 
The Logging Options section of README describes how to specify a file
to log to.  There is a typo, LogFile should be logFile to match the
json.

Fixes #177

Signed-off-by: Michael Cambria <mcambria@redhat.com>
dougbtv pushed a commit that referenced this issue Dec 19, 2018
@mccv1r0 @dougbtv
Fix logFile to match configuration json
fa2e35c 
The Logging Options section of README describes how to specify a file
to log to.  There is a typo, LogFile should be logFile to match the
json.

Fixes #177

Signed-off-by: Michael Cambria <mcambria@redhat.com>
pliurh pushed a commit to pliurh/multus-cni that referenced this issue Sep 22, 2023
@openshift-merge-robot
Merge pull request k8snetworkplumbingwg#177 from s1061123/fix/readiness2
5266a61 
Cherry pick upstream fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mccv1r0