Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CRIO Thin Client Installations #1090

Closed
wants to merge 1 commit into from
Closed

Fix for CRIO Thin Client Installations #1090

wants to merge 1 commit into from

Conversation

rwlove
Copy link

@rwlove rwlove commented May 9, 2023

  1. Use the correct entrypoint

  2. Use /opt/cni/bin for CNI bin dir

@maiqueb
Copy link
Collaborator

maiqueb commented May 16, 2023

@s1061123 does this separate crio daemonset spec even makes sense these days ?

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @rwlove !

I make sense the entrypoint fix, however, I'd like to keep '/usr/libexec/cni' for CNI path. There are two reason:

  • '/usr/libexec/cni' is the default path of Fedora's CNI plugin path. In Fedora38, for example, dnf install containernetworking-plugins installs CNI plugins into '/usr/libexec/cni'.
  • If user uses '/opt/cni/bin' for CNI plugin path, user can use multus-daemonset.yml instead of multus-daemonset-crio.yml because now the difference between '....yml' and '...-crio.yml' (previously we have more difference but now only the CNI path).

So could you please revert the change of CNI path? Thank you again and in advance.

@rwlove
Copy link
Author

rwlove commented May 19, 2023

I understand your feedback and I'll happily update the patch and send a new PR.

@rwlove
Copy link
Author

rwlove commented May 26, 2023

did I update this correctly?

@github-actions
Copy link

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 25, 2023
@github-actions github-actions bot closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants