Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mountPropagation to host-var-lib-kubelet #1300

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add mountPropagation to host-var-lib-kubelet #1300

merged 1 commit into from
Jun 20, 2024

Conversation

adrianchiris
Copy link
Contributor

This is needed to avoid issues with volume unmounts when (other) pods exit as by default kubernetes mounts as private.

@adrianchiris
Add mountPropagation to host-var-lib-kubelet
849a3cd 
This is needed to avoid issues with volume unmounts
when (other) pods exit as by default kubernetes mounts
as private.

Signed-off-by: adrianc <adrianc@nvidia.com>
@coveralls
Copy link

Coverage Status

coverage: 63.116%. remained the same
when pulling 849a3cd on adrianchiris:fix-mount-prop-var-lib-kubelet
into aff99fc on k8snetworkplumbingwg:master.

dougbtv
dougbtv approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to think this is probably a good call, and it fits the other mount propagation that we have for hostroot

@dougbtv dougbtv merged commit 41013e7 into k8snetworkplumbingwg:master Jun 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianchiris @coveralls @dougbtv