Multus should exit zero on DEL when cache file is missing and pod cannot be found. #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 381988023
💛 - Coveralls |
s1061123
reviewed
Nov 24, 2020
| return cmdErr(k8sArgs, "error reading the delegates: %v", err) | ||
| // The options to continue with a delete have been exhausted (cachefile + API query didn't work) | ||
| // We cannot exit with an error as this may cause a sandbox to never get deleted. | ||
| logging.Errorf("Multus: failed to get the cached delegates file: %v, cannot properly delete", err) |
There was a problem hiding this comment.
How about just return after Errorf()? otherwise return delPlugins(...) is invoked and it may also return error...
There was a problem hiding this comment.
+1, thanks for that, agreed. Have an update 👍
…not be found. Otherwise, this can cause a pod to not be fully deleted, its sandbox may remain as the DEL continues to be retried due to exiting non-zero every time. See: https://bugzilla.redhat.com/show_bug.cgi?id=1900835
dougbtv
force-pushed
the
log-error-on-del
branch
from
690b0ce
to
7261295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, this can cause a pod to not be fully deleted, its sandbox may remain as the DEL continues to be retried due to exiting non-zero every time.
See: https://bugzilla.redhat.com/show_bug.cgi?id=1900835