Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container tags for thick plugin #900

Merged
merged 1 commit into from Aug 25, 2022
Merged

Fix container tags for thick plugin #900

merged 1 commit into from Aug 25, 2022

Conversation

s1061123
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.839% when pulling 12c6c91 on s1061123:fix/image-tag into 0c51549 on k8snetworkplumbingwg:master.

dougbtv
dougbtv approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dougbtv dougbtv merged commit 33c0d1b into k8snetworkplumbingwg:master Aug 25, 2022
s1061123 added a commit that referenced this pull request Oct 11, 2022
@s1061123
Fix release 3.x thick image tag to isolate from 4.0
e9b87fb 
Due to #900, image tag, ':thick', which is used in 4.0 and 3.x,
gets user confused because thick image is not compatible between
4.0 and 3.x. This fix provides strict version name in deployment
yaml to specify install image tag.
@s1061123 s1061123 mentioned this pull request Oct 11, 2022
Merged
@s1061123 s1061123 deleted the fix/image-tag branch July 13, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s1061123 @coveralls @dougbtv