Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumbing to optionally build for arm64 #266

Merged
merged 1 commit into from
May 12, 2023

Conversation

courtland
Copy link
Contributor

What this PR does / why we need it:

Adds the ability to optionally build binaries for arm64 by setting GOARCH via Makefile variable overrides.

For example:

make GOARCH=arm64 build

make GOARCH=arm64 docker-build

Also fixes the non-dockerized install-go script to correctly download/install the versioned golang under an arm64 host.

Combined, this permits building the plugin(s) for arm64 and/or x86 on either type of host.

Special notes for your reviewer:

Related to #260

Release note:

Ability to build arm64 binaries

Signed-off-by: Nick Rogers <ncrogers@gmail.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 14, 2023
@kubevirt-bot
Copy link
Collaborator

Hi @courtland. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2023
@courtland courtland mentioned this pull request Apr 14, 2023
@phoracek
Copy link
Member

/retest

@phoracek
Copy link
Member

Hey @courtland, thanks for submitting this. The dockerized tests have failed. Would you please check it?

@courtland
Copy link
Contributor Author

It looks like the quay.io/fedora/fedora:34-x86_64 no longer exists, I'm guessing since 34 was EOL a while back? It must have been right after I submitted this, because the tests passed for me locally then.

I will raise another issue to fix the tests and then perhaps I can rebase this PR.

@phoracek
Copy link
Member

phoracek commented May 8, 2023

/retest

1 similar comment
@phoracek
Copy link
Member

/retest

@phoracek
Copy link
Member

phoracek commented May 12, 2023

/lgtm
/approve
/override pull-e2e-ovs-cni

Failed e2e on an unrelated flake

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: courtland, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2023
@kubevirt-bot kubevirt-bot merged commit 3556fee into k8snetworkplumbingwg:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants