Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check hashicorp: Add hashicorp whitelist #279

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Sep 27, 2023

What this PR does / why we need it:
Validates that no hashicorp are used beside the whitelisted ones
(because they shifted to BSL license)

Special notes for your reviewer:
Atm no hashicorp is used, but lets protect in case someone will add.
Based on the whitelist that CNAO uses.

Release note:

None

@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2023
@oshoval oshoval marked this pull request as ready for review September 27, 2023 08:41
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Member Author

oshoval commented Sep 27, 2023

@phoracek
can you please enable git actions here ?

@oshoval
Copy link
Member Author

oshoval commented Sep 27, 2023

@oshoval
Copy link
Member Author

oshoval commented Oct 1, 2023

/retest

@phoracek
ptal, regression was fixed
we would need please to make sure git actions is enabled

@phoracek
Copy link
Member

phoracek commented Oct 3, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@kubevirt-bot kubevirt-bot merged commit 96fc174 into k8snetworkplumbingwg:main Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants