Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.31] chore: Update golang.org/x/* modules #289

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[release-0.31] chore: Update golang.org/x/* modules #289

merged 2 commits into from
Nov 1, 2023

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Oct 31, 2023 •
edited
Loading

What this PR does / why we need it:
cherry pick
#288
#283

Special notes for your reviewer:

Release note:

None

@courtland @oshoval
fix: bump to fedora:38 in dockerized tests, because 34 is missing
af2b20b 
Signed-off-by: Nick Rogers <ncrogers@gmail.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2023
@oshoval oshoval changed the base branch from main to release-0.31 October 31, 2023 15:26
@oshoval oshoval changed the title chore: Update golang.org/x/* modules [release-0.31] chore: Update golang.org/x/* modules Oct 31, 2023
@0xFelix @oshoval
chore: Update golang.org/x/* modules
f1cb72a 
Updated modules golang.org/x/* to the latest versions.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Member Author

oshoval commented Nov 1, 2023

presubmits of 0.31 passed here (by injecting this PR on the rehearsal)
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3043/rehearsal-pull-e2e-ovs-cni-0.31/1719380196244590592

@phoracek
can you please review this PR ?
once this PR and 3043 are merged we will have the changes and the presubmits together

RamLavi
RamLavi approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@phoracek
Copy link
Member

phoracek commented Nov 1, 2023

/approve

Based on https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3043/rehearsal-pull-e2e-ovs-cni-0.31/1719380196244590592

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek, RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@kubevirt-bot kubevirt-bot merged commit 0ae6cc0 into k8snetworkplumbingwg:release-0.31 Nov 1, 2023
2 checks passed
@oshoval oshoval mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamLavi RamLavi RamLavi approved these changes

Assignees

@RamLavi RamLavi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oshoval @phoracek @kubevirt-bot @RamLavi @courtland @0xFelix