Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.26] chore: Update golang.org/x/* modules #290

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[release-0.26] chore: Update golang.org/x/* modules #290

merged 2 commits into from
Nov 1, 2023

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Oct 31, 2023 •
edited
Loading

What this PR does / why we need it:
Also included
fix: bump to fedora:38 in dockerized tests, because 34 is missing

Created manually because had a conflict
had to run once

go mod tidy -go=1.16 && go mod tidy -go=1.17
go mod vendor

but now make dep is fine

Special notes for your reviewer:

Release note:

None

@courtland @oshoval
fix: bump to fedora:38 in dockerized tests, because 34 is missing
3e14011 
Signed-off-by: Nick Rogers <ncrogers@gmail.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2023
@oshoval
Copy link
Member Author

oshoval commented Nov 1, 2023

Checking the presubmits here
kubevirt/project-infra#3043
still some work to do

@oshoval oshoval force-pushed the cve26 branch 3 times, most recently from 312a087 to 4810d1c Compare November 1, 2023 10:43
@oshoval
[release-0.26] chore: Update golang.org/x/* modules
f166c8a 
Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Member Author

oshoval commented Nov 1, 2023

Passed here
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3043/rehearsal-pull-e2e-ovs-cni-0.26/1719665715784454144

@phoracek
can you please take a look on this PR ?

@phoracek
Copy link
Member

phoracek commented Nov 1, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@kubevirt-bot kubevirt-bot merged commit f2c9623 into k8snetworkplumbingwg:release-0.26 Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oshoval @phoracek @kubevirt-bot @courtland