Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.29] CWE-476: Bump gopkg.in/yaml.v3 #297

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Nov 20, 2023

What this PR does / why we need it:
CWE-476, CWE-400

https://security.snyk.io/vuln/SNYK-GOLANG-GOPKGINYAMLV3-2952714
https://security.snyk.io/vuln/SNYK-GOLANG-GOPKGINYAMLV3-2841557

Special notes for your reviewer:

Release note:

None

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 20, 2023
@kubevirt-bot
Copy link
Collaborator

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni ac0d0ff link true /test pull-e2e-ovs-cni-0.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oshoval
Copy link
Member Author

oshoval commented Nov 20, 2023

@phoracek
Hi, ovs mirror tests are failing, are we allowed to ignore them on OVS repo itself ?
not sure if it is due to the PR or not, they are flaky when used on main but dont know if they are also
flaky on the repo itsef (i believe they are but dont know by heart)

@phoracek
Copy link
Member

/lgtm
/approve

The tests are known to be flaky. Does not seem to be related to this PR.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@oshoval
Copy link
Member Author

oshoval commented Nov 21, 2023

can you please override the lane ?

@phoracek
Copy link
Member

/override pull-e2e-ovs-cni

@phoracek
Copy link
Member

/override pull-e2e-ovs-cni-0.29

@phoracek phoracek merged commit 7374ab8 into k8snetworkplumbingwg:release-0.29 Nov 21, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants