fix: ovsdb.GetOvsPortForContIface should not return error if iface not found #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the function returns
"", false, err
if the interface is not found.The function's signature and usage assume that the function should not return an error if the interface is not found.
ovs-cni/pkg/plugin/plugin.go
Line 315 in 7434914
Fix the function to return
"", false, nil
if the interface is not found.This change fixes CmdDel for the scenario when It is called after a failed CmdAdd or when the port is manually removed from the ovs.
Special notes for your reviewer:
Release note:
cc @SchSeba @e0ne