-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine tune selector based on VF PCI address needed #157
Comments
what about using
|
@zshi-redhat, Please find below my configuration for Intel NIC.
|
@zshi-redhat , They are using the driver of the VFs to select what resource it belongs. So if you have one PF and they half VF to be DPDK and half to netdevice, with intel is simple because they have dpdk driver and netdevice vf driver. With Mellanox dpdk and netdevice are using the same driver so we don't have away to differentiate between them. I think we should have selector which is regex on VF interface names. Something like vfName: eth[0-4] |
@moshe010 |
@ark-g, we don't want to do pci address config, because this is across all servers. I would expect you will put a udev rule to make sure the VF name are consistent across all servers |
@moshe010 , you are right that it is possible, but it requires additional system configuration in udev, that I would like to avoid. |
@moshe010 thanks for the explanation! |
@zshi-redhat |
@ark-g, Why intel approach force to split it you can just specific "drivers": ["igb_uio", "i40evf"] also you don't need the "sriovMode" and "deviceType" it was in the old config. |
@moshe010 |
I think the allocation is done by kubelet, so this won't help you. (I guess) |
@ahalim-intel any thoughts on this? |
just to provide more context we talked extending the pfName selector to support also the following: |
@moshe010 |
yes, it make sense |
If I understand the use case correctly, the combination if "pfNames" and "drivers" will let you define your resource pool. You may have VFs under same PF either kernel driver or dpdk driver, device plugin will pick the right VF based on the selectors criteria. Once you have your resource pool configured correctly then it's up to you decide which pods gets what through resource requests or net CRDs. |
@ahalim-intel |
If there are no conceptual objections, then should I start to prepare POC code ? |
@ahalim-intel I understand this is to split VFs from same PF into separate resource groups even if VFs are bind to same driver.
|
closing - feature has been implemented #165 |
I have a situation when the existing selectors for Mellanox NIC is not enough to define groups of VF's, so I think it is worth to define additional selector that will allow to choose specific VF from each physical port to some group/configuration.
Issue:
For Intel NIC I am doing bind VF's to different drivers (igb_uio and i40evf) before running sriov-network-device-plugin, and then, using "driver" selector to split VF's to different groups.
For Mellanox NIC it is not possible, since it uses the same driver for both DPDK and regular interfaces.
So I suggest to have a 'fine-tune' selector to choose specific VF PCI addresses for each group/configuration, but any other solution/advice is also welcome.
Thanks.
The text was updated successfully, but these errors were encountered: