Clean up Makefile variables and comments #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export GOPATH | ||
| export GOBIN | ||
|
|
||
| # Docker |
There was a problem hiding this comment.
even after the refactoring i would prefer if we could group the variables according to their related usage, e.g have a comment stating that the following variables are docker related so they are not bunched in a single long list of variables.
| @@ -37,11 +41,9 @@ ifdef STATIC | |||
| LDFLAGS=-a -ldflags '-extldflags \"-static\"' | |||
| endif | |||
|
|
|||
| # Go tools | |||
| GO = go | |||
There was a problem hiding this comment.
While this is best practice in C/C++ where different compilers are used, i think we only have one compiler in go right ?
So im fine with not having this as a parameter (i also see that other parts of this makefile directly reference go compiler directly)
|
|
||
| # Docker image | ||
| # To pass proxy for Docker invoke it as 'make image HTTP_POXY=http://192.168.0.1:8080' |
There was a problem hiding this comment.
nit: i think its not half bad to keep this comment.
Keep all variables at the top of the file Remove unused and/or unnecessary variables Delete unnecessary comments
Signed-off-by: Rymsza, MonikaX <monikax.rymsza@intel.com>
martinkennelly
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep all variables at the top of the file
Remove unused and/or unnecessary variables
Delete unnecessary comments
Fixes #291