Remove IsSriovPF as unused method of PciDevice interface

[DmytroLinkin]

This check is done by utility function with the same name, hence
remove method as unused.

Signed-off-by: Dmytro Linkin dlinkin@nvidia.com

[DmytroLinkin]

/CC @adrianchiris

There is also unused GetSubClass method, but I supposed it's gonna be used with PCI SubClass implementation in the future.

[coveralls]

Pull Request Test Coverage Report for Build 2676592614

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.1%) to 76.623%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/resources/pciDevice.go	2	55.91%

Totals
Change from base Build 2663118240:	0.1%
Covered Lines:	1570
Relevant Lines:	2049

---

💛 - Coveralls

[adrianchiris]

Hi @DmytroLinkin ! thanks for working on this cleanup.

There is also unused GetSubClass method, but I supposed it's gonna be used with PCI SubClass implementation in the future.

it just returns PCI subclass attribute which is not being used throughout the code. im not sure what you are referring in rgards to future use of this method.

IMO it can also be removed. that said, it can be done in a followup PRd.

[DmytroLinkin]

Mostly I'm talking about this lines
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/master/pkg/types/types.go#L63-L78
Which along with GetSubClass suggests that there can be such support in the future.

[adrianchiris]

@DmytroLinkin can you rebase ? we can merge this one IMO