vhost-vdpa: fix DeviceInfo file content #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
approved these changes
Jul 4, 2023
|
/retest |
|
Return error instead and handle it at the call sites. |
SchSeba
approved these changes
Jul 13, 2023
|
@bn222 AFAIK there is no error condition to be handled at the call site. Let's say, if a path is returned, it'll be used to fill some structs, otherwise an empty path will be stored instead. The glog.Infof is just for convenience. |
|
It seems to me that whenever this function returns "", it was due to it being called on something that doesn't have this path, i.e. it should not have been called on it the first place? |
|
Added error handling for GetPath function |
lmilleri
force-pushed
the
vhost-vdpa
branch
2 times, most recently
from
4f4bf71
to
f26c266
Compare
|
/lgtm |
pkg/infoprovider/vdpaInfoProvider.go
Outdated
| vdpaPath, err := vip.dev.GetPath() | ||
| if err != nil { | ||
| glog.Errorf("Unexpected error when fetching the vdpa device path: %s", err) | ||
| return devSpecs |
There was a problem hiding this comment.
shouldn't we return nil explicitly like above ? (When device not healthy)
There was a problem hiding this comment.
I think it would be safer, will do the change thanks!
The path attribute in the DeviceInfo specification is now set to something like '/dev/vhost-vdpa-0'. See issue k8snetworkplumbingwg#492 Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
Pull Request Test Coverage Report for Build 5588346567
💛 - Coveralls |
adrianchiris
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the DeviceInfo file generation for vhost-vdpa devices.
For details please check the following issue:
#492