Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize modern taint in demo #496

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Recognize modern taint in demo #496

merged 1 commit into from
Aug 9, 2023

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Aug 2, 2023

Modern kubernetes does not set the master designation any longer. This patch adds in support for control-plane while preserving the old behavior.

@jcpunk
Recognize modern taint in demo
173ea4d 
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
SchSeba
SchSeba approved these changes Aug 6, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for the PR

@adrianchiris adrianchiris merged commit 063a9e9 into k8snetworkplumbingwg:master Aug 9, 2023
10 checks passed
@jcpunk jcpunk deleted the control-plane-tolleration branch August 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcpunk @SchSeba @adrianchiris