Add support for Broadcom NICs #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -198,6 +199,15 @@ This plugin creates device plugin endpoints based on the configurations given in | |||
| "needVhostNet": true | |||
| }] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
please add at the end of the list before: "old_selectors_syntax_example"
deployments/configMap.yaml
Outdated
| @@ -23,6 +23,14 @@ data: | |||
| "pfNames": ["enp0s0f0","enp2s2f1"] | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
please add at the end of the list
|
minor nit, otherwise LGTM ! thx for testing it out of broadcom |
Pull Request Test Coverage Report for Build 6946547658Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
adrianchiris
approved these changes
Nov 21, 2023
|
I have pushed requested changes. |
|
@adrianchiris Thank you very much for the review and approval. Can you please merge? |
|
communitiy rules requires 2 approvals. @zeeke @Eoghan1232 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have verified that SRIOV plugin works with Broadcom NICs. This request is adding Broadcom NICs to Readme and adding an example of a working configuration.