Fix openshift conformance test #128
Conversation
|
For |
zshi-redhat
force-pushed
the
fix-openshift-conformance-test
branch
from
7b10bb2
to
9f64903
Compare
Updated to 25% |
| @@ -11,6 +11,8 @@ spec: | |||
| matchLabels: | |||
| app: sriov-network-config-daemon | |||
| updateStrategy: | |||
| rollingUpdate: | |||
| maxUnavailable: 25% | |||
There was a problem hiding this comment.
According to https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set, the default value is 1 for daemonse.
There was a problem hiding this comment.
Thanks for the comments!
Updated.
There was a problem hiding this comment.
Hmm, I tried to verify this PR by running the tests. It will fail the test unless this value is set to either 10% or 33%. So neither 25% nor 1 would work.
There was a problem hiding this comment.
Should we set it to 33% instead?
There was a problem hiding this comment.
Updated to 33%.
zshi-redhat
force-pushed
the
fix-openshift-conformance-test
branch
from
9f64903
to
89eabb6
Compare
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 1000Mi |
There was a problem hiding this comment.
How did you determine the memory request of 1 GB for this daemonset? Seems a little large.
There was a problem hiding this comment.
Good question, I didn't measure how much memory the config daemon would require.
My concern was to not make this smaller enough that would affect current deployment. But I agree that it's a little large.
I will make a change to reduce it to 100Mi.
Thanks @martinkennelly !
zshi-redhat
force-pushed
the
fix-openshift-conformance-test
branch
from
89eabb6
to
e3a296a
Compare
|
Hi @zshi-redhat can you please also add it for the operator under the bundle? |
https://bugzilla.redhat.com/show_bug.cgi?id=1957761 Signed-off-by: Zenghui Shi <zshi@redhat.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1958107 Signed-off-by: Zenghui Shi <zshi@redhat.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1960574 Signed-off-by: Zenghui Shi <zshi@redhat.com>
zshi-redhat
force-pushed
the
fix-openshift-conformance-test
branch
from
c173ca6
to
4293b8c
Compare
Signed-off-by: Zenghui Shi <zshi@redhat.com>
Done |
No description provided.