Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump CNI version for the sriov-cni #665

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Mar 24, 2024

No description provided.

Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Mar 24, 2024

@e0ne
Copy link
Collaborator

e0ne commented Mar 25, 2024

@SchSeba please, fix unit-tests to get this merged

@SchSeba
Copy link
Collaborator Author

SchSeba commented Mar 27, 2024

yep I will do it I am waiting for all the other PRs first

@SchSeba
Copy link
Collaborator Author

SchSeba commented Mar 27, 2024

/hold

Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Apr 15, 2024

/hold cancel

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@github-actions github-actions bot removed the hold label Apr 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8688728582

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 38.37%

Files with Coverage Reduction New Missed Lines %
controllers/generic_network_controller.go 5 74.53%
Totals Coverage Status
Change from base Build 8605771976: -0.03%
Covered Lines: 4802
Relevant Lines: 12515

💛 - Coveralls

@SchSeba
Copy link
Collaborator Author

SchSeba commented Apr 18, 2024

@e0ne @zeeke please take a look small PR :)

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit c5d4773 into k8snetworkplumbingwg:master Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants