Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network status annotation to k8s.v1.cni.cncf.io/network-status #308

Merged
merged 2 commits into from Mar 15, 2023

Conversation

andreaskaris
Copy link
Contributor

Use the correct annotation string k8s.v1.cni.cncf.io/network-status directly from k8snetworkplumbingwg/network-attachment-definition-client

Fixes https://issues.redhat.com/browse/OCPBUGS-10328

Use the correct annotation string k8s.v1.cni.cncf.io/network-status
directly from k8snetworkplumbingwg/network-attachment-definition-client

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@maiqueb
Copy link
Collaborator

maiqueb commented Mar 15, 2023

You'll need to make peace with the linter @andreaskaris ... Sorry for that.
https://github.com/k8snetworkplumbingwg/whereabouts/actions/runs/4427149396/jobs/7764419119?pr=308

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
Copy link
Contributor Author

/retest

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4427889727

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.009%

Totals Coverage Status
Change from base Build 4417057589: 0.0%
Covered Lines: 943
Relevant Lines: 1328

💛 - Coveralls

@maiqueb maiqueb merged commit 87e95f1 into k8snetworkplumbingwg:master Mar 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants