Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove current usages of managed-by label #859

Closed
Tracked by #842
olim7t opened this issue Feb 8, 2023 · 0 comments · Fixed by #858
Closed
Tracked by #842

Remove current usages of managed-by label #859

olim7t opened this issue Feb 8, 2023 · 0 comments · Fixed by #858
Assignees
@olim7t
Labels
done Issues in the state 'done' refactoring

Comments

@olim7t
Copy link
Contributor

olim7t commented Feb 8, 2023 •
edited

We currently use app.kubernetes.io/managed-by (and its associated functions such as labels.IsManagedBy):

  • for replicated secrets: as part of the selector expression that determines which secrets to replicate;
  • for per-node config maps and Vector config maps: as a way to set the two other label that allows us to "watch" those components in the K8ssandraCluster controller.

managed-by is part of the Recommended labels that Kubernetes suggests applying to every component; it should be for information purposes only, associating semantic meaning with it can be misleading.

We propose removing its current usages:

  • for replicated secrets, replace it with a custom label.
  • for config maps, it is not needed, the other two are sufficient (and in fact the code that sets up the watch in the controller does not even test for it).

managed-by will be reintroduced in #861, but as a common label that gets applied to every component, without any underlying semantics.
@olim7t olim7t added the bug Something isn't working label Feb 8, 2023
This was referenced Feb 8, 2023
Closed
Merged
@olim7t olim7t added refactoring and removed bug Something isn't working labels Feb 8, 2023
@adejanovski adejanovski added the in-progress Issues in the state 'in-progress' label Feb 8, 2023
olim7t added a commit that referenced this issue Feb 9, 2023
@olim7t
Remove current usages of managed-by label (fixes #859) (#858)
ce53c13 
* Use a dedicated label for ReplicatedSecret selector
* Don't use managed-by to set watches

This is part of a larger refactoring of labels. managed-by will be re-added as part of a "common" set applied to all components, but without any logic attached to it.
@adejanovski adejanovski added done Issues in the state 'done' and removed in-progress Issues in the state 'in-progress' labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olim7t olim7t

Labels
done Issues in the state 'done' refactoring
Projects
K8ssandra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove current usages of managed-by label (fixes #859) olim7t/k8ssandra-operator
2 participants
@olim7t @adejanovski