K8SSAND-1501 ⁃ cass-operator ConfigMap image_config.yaml is broken

[Gellardo]

Bug Report

Describe the bug
Cass-operator configmap uses imagePullSecrets (here) even though cass-operator config is named imagePullSecret (here) and in fact can't handle more than one secret name.

Also imageRegistry (here) and imagePullPolicy are indented too much.

To Reproduce
Steps to reproduce the behavior:

1. Go to charts/cass-operator
2. helm template . --set 'image.registryOverride=registry,imagePullSecrets[0].name=pull-secret' > output.yaml
3. Find the ConfigMap

kind: ConfigMap
metadata:
  name: release-name-cass-operator-manager-config
  [...]
apiVersion: v1
data:
  controller_manager_config.yaml: |
    [...]
  image_config.yaml: |
    apiVersion: config.k8ssandra.io/v1beta1
    kind: ImageConfig
    images:
      system-logger: "k8ssandra/system-logger:v1.10.0"
      config-builder: "datastax/cass-config-builder:1.0.4-ubi7"
      imageRegistry: asdf
    imagePullSecrets:
        - name: hi
      imagePullPolicy: IfNotPresent
    defaults:
      [...]

Expected behavior
It is possible to add multiple imagePullSecrets to the pods generated by the operator. This is probably not possible without changes to the operator itself.

Pure Chart fix: expected output from my understanding of the current cass-operator config:

kind: ConfigMap
metadata:
  name: release-name-cass-operator-manager-config
  [...]
apiVersion: v1
data:
  controller_manager_config.yaml: |
    [...]
  image_config.yaml: |
    apiVersion: config.k8ssandra.io/v1beta1
    kind: ImageConfig
    images:
      system-logger: "k8ssandra/system-logger:v1.10.0"
      config-builder: "datastax/cass-config-builder:1.0.4-ubi7"
-     imageRegistry: asdf
+   imageRegistry: asdf
-   imagePullSecrets:
-       - name: hi
+   imagePullSecret:
+       name: hi
-     imagePullPolicy: IfNotPresent
+   imagePullPolicy: IfNotPresent
    defaults:
      [...]

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1501
┆priority: Medium

[jsanda]

Hi @Gellardo

Thanks for opening the issue.

It is possible to add multiple imagePullSecrets to the pods generated by the operator. This is probably not possible without changes to the operator itself.

That's right. It will require a change in cass-operator. I went ahead and created k8ssandra/cass-operator#341.

This may be fixed by #1421.

[jsanda]

This was fixed by #1421.