Add clusterName cleanup similar to cass-operator to k8ssandra [K8SSAND-873] #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
approved these changes
Nov 30, 2021
adejanovski
requested changes
Nov 30, 2021
jdonenine
changed the title
burmanm
force-pushed
the
fix_clustername_helm_template
branch
from
6b24cc9
to
153e14c
Compare
adejanovski
approved these changes
Dec 1, 2021
adejanovski
pushed a commit
that referenced
this pull request
Dec 1, 2021
…D-873] (#1208) * Add clusterName cleanup similar to cass-operator to k8ssandra * Add changelog * Move changelog from 1.5 to 1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds similar clusterName cleanup to our Helm templates as we have in cass-operator. This is because some of the resources created by k8ssandra helm charts are not using cass-operator's logic.
Allows "broken" clusterNames which do not conform to DNS rules.
Which issue(s) this PR fixes:
Fixes #1090
Checklist