Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added s3_rgw support #1415

Merged
merged 2 commits into from
Jun 8, 2022
Merged

added s3_rgw support #1415

merged 2 commits into from
Jun 8, 2022

Conversation

dyvol777
Copy link
Contributor

@dyvol777 dyvol777 commented May 30, 2022

What this PR does:
added s3_rgw support

this change won't break anything

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@dyvol777 dyvol777 requested a review from a team as a code owner May 30, 2022 14:08
@jsanda
Copy link
Contributor

jsanda commented Jun 7, 2022

Thanks for the PR @dyvol777. Can you please sign the CLA if you haven't already done so? And can you also update the changelog?

@dyvol777
Copy link
Contributor Author

dyvol777 commented Jun 7, 2022

I'm sorry, but i didn't find any info in repo on how to sign the CLA. Can you give me a bit information about it?
And for changelog, i should add it for 1.6.0 or 1.5.1?

@adejanovski
Copy link
Contributor

I'm sorry, but i didn't find any info in repo on how to sign the CLA. Can you give me a bit information about it?
And for changelog, i should add it for 1.6.0 or 1.5.1?

Hi,
The CLA is linked in the PR description: https://cla.datastax.com/

The changelog should be the 1.6.0 since this isn't a bug fix and will ship in our next minor release.

Thanks!

@dyvol777
Copy link
Contributor Author

dyvol777 commented Jun 7, 2022

signed the CLA and added changelog

@adejanovski
Copy link
Contributor

@dyvol777, quick question: wouldn't s3_compatible work for using CEPH RGW as backend?

@dyvol777
Copy link
Contributor Author

dyvol777 commented Jun 8, 2022

I hoped it would. But I tried and it didn't work. In the logs of the medusa container i saw:
[2022-06-01 19:06:47,341] DEBUG: https://rgw_url:443 "HEAD /cassandra-backups HTTP/1.1" 403 0
Credentials was correct. Using aws cli i can list all files.
I didn't find any usefull information about this, if you could help me with that - it would be great

@adejanovski adejanovski merged commit 5c7564e into k8ssandra:main Jun 8, 2022
@adejanovski
Copy link
Contributor

Let's roll with s3_rgw then. Thanks for pushing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants