Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JVM options heap inclusion #242

Merged
merged 3 commits into from
Jan 27, 2021
Merged

JVM options heap inclusion #242

merged 3 commits into from
Jan 27, 2021

Conversation

jeffbanks
Copy link
Contributor

@jeffbanks jeffbanks commented Jan 25, 2021 •
edited

Provides cluster, dc, and default jvm heap option configurations as described in #158.

Design Notes

@jeffbanks jeffbanks requested a review from jsanda January 25, 2021 17:16
@jeffbanks jeffbanks self-assigned this Jan 25, 2021
@jeffbanks jeffbanks added this to In progress in K8ssandra via automation Jan 25, 2021
@jeffbanks jeffbanks added this to the 1.0.0 milestone Jan 25, 2021
@jeffbanks jeffbanks linked an issue Jan 25, 2021 that may be closed by this pull request
Make Cassandra heap size configurable #158
Closed
@jeffbanks jeffbanks moved this from In progress to Review in progress in K8ssandra Jan 25, 2021
jsanda
jsanda requested changes Jan 26, 2021
View reviewed changes
charts/k8ssandra/templates/cassandra/cassdc.yaml Outdated Show resolved Hide resolved
charts/k8ssandra/templates/cassandra/cassdc.yaml Outdated Show resolved Hide resolved
tests/unit/template_cassdc_test.go Outdated Show resolved Hide resolved
tests/unit/template_cassdc_test.go Outdated Show resolved Hide resolved
@jeffbanks
Copy link
Contributor Author

Updated values.yaml to include description of optional dc-level and cluster-level settings.

  • The default settings for min, max, and newGen sizes are no longer being provided.
  • The recommended values for min and max are to be set to the same value.
  • The recommended newGen size is half of the min and max.

jsanda
jsanda requested changes Jan 27, 2021
View reviewed changes
charts/k8ssandra/templates/cassandra/cassdc.yaml Outdated Show resolved Hide resolved
charts/k8ssandra/templates/cassandra/cassdc.yaml Outdated Show resolved Hide resolved
charts/k8ssandra/templates/cassandra/cassdc.yaml Outdated Show resolved Hide resolved
charts/k8ssandra/templates/cassandra/cassdc.yaml Outdated Show resolved Hide resolved
@jsanda jsanda mentioned this pull request Jan 27, 2021
Closed
@jeffbanks jeffbanks requested a review from jsanda January 27, 2021 17:42
jsanda
jsanda approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@jsanda jsanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffbanks nice work!

K8ssandra automation moved this from Review in progress to Reviewer approved Jan 27, 2021
@jsanda jsanda merged commit ee4e1c3 into main Jan 27, 2021
K8ssandra automation moved this from Reviewer approved to Done Jan 27, 2021
@jsanda jsanda deleted the jvm-options-expansion branch January 27, 2021 20:56
@jeffbanks jeffbanks mentioned this pull request Feb 10, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanda jsanda jsanda approved these changes

@burmanm burmanm Awaiting requested review from burmanm

Assignees

@jeffbanks jeffbanks

Labels
complexity:medium
Projects
No open projects
K8ssandra
  
Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Make Cassandra heap size configurable
3 participants
@jeffbanks @jsanda @burmanm