Upgrade Stargate and improve doc comments for stargate.image #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerobb
changed the title
|
I sanity checked Stargate 1.0.9 against C* 3.11.10 and 4.0.0beta4. All is well; I think this is ready to merge. |
jdonenine
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
I finished up my side of the testing on 4.0, looks good with the bump of version and the removal of the property from values.yaml.
I talked to John quickly about removing from values.yaml to give him the heads up there, so if you're done testing 3.x @jakerobb I think we're good.
jeffreyscarpenter
pushed a commit
to jeffreyscarpenter/k8ssandra
that referenced
this pull request
Mar 10, 2021
…ra#403) * improved doc comments for stargate.image * Updated Stargate to 1.0.9 * Remove stargate.clusterVersion from values.yaml (k8ssandra#405) Co-authored-by: Jeff DiNoto <jeff.dinoto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrades Stargate to 1.0.9
Adds a bit of clarity to the doc comment for stargate.version
This is in draft mode because the images for 1.0.9 have not yet been published to Docker Hub. The changes themselves should be final, but I need to test with a cluster using the actual images.
Which issue(s) this PR fixes:
None
Checklist