-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chart dependencies #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 417-debug: update chart version remove OpenAPI schema validation that is causing errors in k8s 1.16 # Conflicts: # charts/k8ssandra/Chart.yaml
…7-debug-merge * 'main' of github.com:k8ssandra/k8ssandra: Fix scale up/down examples (#427)
I ran another test after adding in the missing packages from what @bradfordcp had done, linting passes now, tests pass now, and a full end-to-end test went as expected with a full test of stargate and a backup/restore cycle. I will un-draft this so that @jsanda has it at his disposal as we stage to merge the last few fixes. |
jsanda
approved these changes
Feb 24, 2021
5 tasks
jeffreyscarpenter
pushed a commit
to jeffreyscarpenter/k8ssandra
that referenced
this pull request
Mar 10, 2021
* remove OpenAPI schema validation that is causing errors in k8s 1.16 * update chart version * Update packages that were missing * update medusa-operator and move backup/restore CRDs * bump chart version Co-authored-by: John Sanda <john.sanda@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is the result of @jsanda 's research into #417 where he noticed that we were including older chart tarballs. The merge here is a branch that was a merge between @jsanda 's 417-debug branch and main so that I could test the newer medusa/reaper inclusions with what was done in 417-debug. 417-debug also included the fix for some label indentation issues that were found.
To verify the chart changes @burmanm @jsanda and I diffed all of the included charts for changes and I have tested initially against 417-debug only and then next with the combination of 417-debug and main. On both k8s v1.17.17 and v1.18.15.
Hopefully we don't get into this situation again with the help of #419 in the future.
Which issue(s) this PR fixes:
Partially Fixes #417
Checklist