Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make secret name templates consistent #435

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

jsanda
Copy link
Contributor

@jsanda jsanda commented Feb 25, 2021

What this PR does:
This makes the logic consistent across the k8ssandra.<component>UserSecretName templates. It also updates the code that calls these templates.

Which issue(s) this PR fixes:

Checklist

  • Changes manually tested
  • Chart versions updated (if necessary)
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@jsanda jsanda self-assigned this Feb 25, 2021
@jsanda jsanda added this to In progress in K8ssandra via automation Feb 25, 2021
K8ssandra automation moved this from In progress to Reviewer approved Feb 25, 2021
Copy link
Contributor

@jdonenine jdonenine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . Did some testing with the branch, looked good!

@jdonenine jdonenine merged commit 1ae8271 into k8ssandra:main Feb 25, 2021
K8ssandra automation moved this from Reviewer approved to Done Feb 25, 2021
jeffreyscarpenter pushed a commit to jeffreyscarpenter/k8ssandra that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
K8ssandra
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants