Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tolerations configurable #46

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

jsanda
Copy link
Contributor

@jsanda jsanda commented May 13, 2021

@sonarcloud
Copy link

sonarcloud bot commented May 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jsanda jsanda requested review from jeffbanks and burmanm May 13, 2021 02:32
Copy link
Contributor

@jeffbanks jeffbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of comments for your review.

api/v1alpha1/zz_generated.deepcopy.go Show resolved Hide resolved
tolerations:
description: Tolerations applied to the Reaper pods
items:
description: The pod this Toleration is attached to tolerates any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tolerates -> tolerate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That description comes from the Toleration docs which is part of the core k8s api.

set, which means tolerate the taint forever (do not evict).
Zero and negative values will be treated as 0 (evict immediately)
by the system.
format: int64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format seems a bit high at int64 since it allows for not setting a value to tolerate the taint forever.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. This is part of the core Toleration type.

@jsanda jsanda merged commit 6d01ad2 into k8ssandra:master May 14, 2021
@jsanda jsanda deleted the tolerations branch May 14, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants