deps: update the stack to NRT API v1alpha2 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
nice, basic smoke tests passed, I'll run more tests (which unfortunately can't run on our CI, that's also a gap) locally and we will iterate over there. |
ffromani
force-pushed
the
update-api-v1a2
branch
from
7d8426b
to
91028de
Compare
import from github.com/k8stopologyawareschedwg/noderesourcetopology-api@v0.1.1 Signed-off-by: Francesco Romani <fromani@redhat.com>
RTE >= v0.10.0 requires API v1alpha2 Signed-off-by: Francesco Romani <fromani@redhat.com>
the scheduler plugin was updated to require API >= v1alpha2 Signed-off-by: Francesco Romani <fromani@redhat.com>
the node-topology-updater was updated to require API >= v1alpha2 Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
update-api-v1a2
branch
from
91028de
to
eee469e
Compare
to do very basic test the scheduler behaves correctly. Signed-off-by: Francesco Romani <fromani@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neither scheduler-plugins nor NFD had releases yet, so we need to use snapshots. From deployer proper perspective, doesn't change much though.
Fixes #147