-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: allow to specify namespace #77
Conversation
/hold |
I don't see the benefit for the deployer here, could you please elaborate? |
It'll allow selecting the namespace where you want the scheduler to get deployed in the deployer as well |
but in the deployer we do want to have opinionated defaults. Selecting the namespace will create more complications and we don't have a usecase for that yet. So maybe let's start with the use case in the contex to of the deployer, so we can evaluate the best solution. |
This change is good in general, but also will help with implementing the scheduler deployment in NROP. The change is completely optional and won't affect the default behavior Signed-off-by: Talor Itzhak <titzhak@redhat.com>
And we do, in case that the namespace is not provided we're staying with the default.
I mentioned the context in the PR, but I can elaborate more if needed Anyhow, I also have a workaround in case we don't want to have this patch in the deployer (it's just that the workaround is a bit ugly and has some copy-paste from the original deployer code) |
True, but then we need to support (and test) this option, whose benefit is still not clear to me |
wrong button |
OK let's leave it for now, we can discuss this PR again once I'll have the changes in NROP ready. |
This change is good in general, but also will help with implementing the scheduler deployment in NROP.
The change is completely optional and won't affect the default behavior
Signed-off-by: Talor Itzhak titzhak@redhat.com