Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daemonset chart option #43

Closed
brightdroid opened this issue Nov 26, 2022 · 6 comments · Fixed by #44
Closed

Daemonset chart option #43

brightdroid opened this issue Nov 26, 2022 · 6 comments · Fixed by #44
Assignees
@yonatankahana
Labels
enhancement New feature or request

Comments

@brightdroid
Copy link

It would be nice if you add a values-option to use a Daemonset instead of deployment.

Thank you in advance
@yonatankahana yonatankahana mentioned this issue Nov 27, 2022
Merged
@yonatankahana yonatankahana self-assigned this Nov 27, 2022
@yonatankahana yonatankahana added enhancement New feature or request helm labels Nov 27, 2022
@brightdroid
Copy link
Author

Thank you 👍

@brightdroid
Copy link
Author

Did you forget to push a new version? Version 0.10.0 doesn't have the new kind value.

Thanks you again

@yonatankahana
Copy link
Member

hi @brightdroid, the changes have been merged but not yet released. I am planning to release v0.11.0 as soon as #45 will be merged

@brightdroid
Copy link
Author

Ok, thank you.

@yonatankahana
Copy link
Member

@brightdroid you can now use this feature in chart version 0.11.0

@brightdroid
Copy link
Author

Thank you, works as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yonatankahana yonatankahana

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helm: add option to use daemonset instead of deployment yonatankahana/k8tz
2 participants
@brightdroid @yonatankahana