Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for managing certificate with cert-manager #45

Merged
merged 11 commits into from
Dec 8, 2022
Merged

feat: add support for managing certificate with cert-manager #45

merged 11 commits into from
Dec 8, 2022

Conversation

kmdrn7
Copy link
Contributor

@kmdrn7 kmdrn7 commented Nov 29, 2022

add ability to use cert-manager self-sign issuer to generate the certificate used by the webhook

this feature flag can be configured using

webhook:
  certManager:
    enabled: true
    issuerRef:
      name: selfsigned
      kind: Issuer

yonatankahana
yonatankahana requested changes Nov 29, 2022
View reviewed changes
charts/k8tz/templates/certificate.yaml Outdated Show resolved Hide resolved
charts/k8tz/values.yaml Show resolved Hide resolved
charts/k8tz/templates/certificate.yaml Show resolved Hide resolved
@yonatankahana
Copy link
Member

please ignore the failing helm test - it is not your mistake, its coming from master. I'll fix it in the next chart version (which will be released after your PR + #44 merged)

@k8tz k8tz deleted a comment from codecov-commenter Nov 29, 2022
@yonatankahana yonatankahana self-assigned this Nov 29, 2022
@yonatankahana yonatankahana added enhancement New feature or request area/helm Helm chart area labels Nov 29, 2022
@yonatankahana
Copy link
Member

can you please resolve the conflict with master?

yonatankahana
yonatankahana requested changes Dec 2, 2022
View reviewed changes
charts/k8tz/values.yaml Outdated Show resolved Hide resolved
yonatankahana
yonatankahana requested changes Dec 2, 2022
View reviewed changes
charts/k8tz/README.md Outdated Show resolved Hide resolved
charts/k8tz/README.md Outdated Show resolved Hide resolved
@yonatankahana yonatankahana mentioned this pull request Dec 3, 2022
Closed
yonatankahana
yonatankahana requested changes Dec 6, 2022
View reviewed changes
charts/k8tz/README.md Outdated Show resolved Hide resolved
charts/k8tz/README.md Outdated Show resolved Hide resolved
@yonatankahana yonatankahana merged commit cc986a7 into k8tz:master Dec 8, 2022
@yonatankahana
Copy link
Member

@kmdrn7 thank you very much for you contribution 😃👍

@kmdrn7
Copy link
Contributor Author

kmdrn7 commented Dec 13, 2022

sure @yonatankahana , thanks for the guidance as well 😄

@kmdrn7 kmdrn7 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonatankahana yonatankahana yonatankahana approved these changes

Assignees

@yonatankahana yonatankahana

Labels
area/helm Helm chart area enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmdrn7 @yonatankahana