helm: allow to set additional namespace labels #100
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 6 6
Lines 839 839
=======================================
Hits 564 564
Misses 238 238
Partials 37 37 ☔ View full report in Codecov by Sentry. |
charts/k8tz/values.yaml
Outdated
| @@ -66,7 +67,8 @@ service: | |||
| type: ClusterIP | |||
| port: 443 | |||
|
|
|||
| resources: {} | |||
There was a problem hiding this comment.
please don't change unrelated lines
like pod security enforcement labels : https://kubernetes.io/docs/tasks/configure-pod-container/enforce-standards-namespace-labels/
maitredede
force-pushed
the
helm-namespace-labels
branch
from
3e6a270
to
3af15bb
Compare
|
Hello, thanks for your review. The unwanted changes were caused by code formatter. Sorry for the inconvenience. |
| @@ -5,6 +5,7 @@ replicaCount: 1 | |||
|
|
|||
| namespace: k8tz # set to `null` to use helm built-in namespace | |||
| createNamespace: true # set to `false` to disable namespace creation by the helm chart | |||
| namespaceLabels: {} | |||
There was a problem hiding this comment.
please document the new option in chart readme: https://github.com/k8tz/k8tz/tree/master/charts/k8tz#values
like pod security enforcement labels : https://kubernetes.io/docs/tasks/configure-pod-container/enforce-standards-namespace-labels/