Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove volummount implanted by other operators to avoid conflicts #27

Merged
merged 6 commits into from
Jul 30, 2022

Conversation

chenhuazhong
Copy link
Contributor

Some operators will automatically create pods with "/etc/localtime" volumemounts, which will lead to volumemounts conflicts,

The Pod "nginx" is invalid:

  • spec.containers[0].volumeMounts[4].mountPath: Invalid value: "/etc/localtime": must be unique
  • spec.containers[0].volumeMounts[5].mountPath: Invalid value: "/usr/share/zoneinfo": must be unique

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #27 (0a8e32d) into master (745ec3f) will increase coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   73.73%   74.53%   +0.79%     
==========================================
  Files           5        5              
  Lines         575      593      +18     
==========================================
+ Hits          424      442      +18     
  Misses        117      117              
  Partials       34       34              
Impacted Files Coverage Δ
pkg/inject/inject.go 93.75% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745ec3f...0a8e32d. Read the comment docs.

pkg/inject/inject.go Outdated Show resolved Hide resolved
@yonatankahana yonatankahana added bug Something isn't working area/injection Patch Injections area labels Jul 22, 2022
pkg/inject/transform_test.go Show resolved Hide resolved
pkg/inject/inject.go Outdated Show resolved Hide resolved
@yonatankahana yonatankahana merged commit 44962cc into k8tz:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/injection Patch Injections area bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants