refactor(logs): improve admission controller logs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonatankahana
force-pushed
the
admission-logs
branch
from
2e72198
to
0906cdd
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 74.53% 74.79% +0.25%
==========================================
Files 5 5
Lines 593 603 +10
==========================================
+ Hits 442 451 +9
- Misses 117 118 +1
Partials 34 34
Continue to review full report at Codecov.
|
yonatankahana
force-pushed
the
admission-logs
branch
from
0906cdd
to
fe21faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve existing logs and add verbose logs for debugging. the verbose logger can be enabled with helm (
--set verbose=true)