override injected initContainer name #84
Conversation
- introduce new value `injectedInitContainerName` - add default value for `injectedInitContainerName` - add `--container-name` to controller args - update documentations
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 67.66% 67.57% -0.09%
==========================================
Files 6 6
Lines 838 842 +4
==========================================
+ Hits 567 569 +2
- Misses 234 236 +2
Partials 37 37
☔ View full report in Codecov by Sentry. |
| @@ -431,6 +431,7 @@ func TestPatchGenerator_createInitContainerPatches(t *testing.T) { | |||
| type fields struct { | |||
| Strategy InjectionStrategy | |||
| Timezone string | |||
| InitContainerName string | |||
There was a problem hiding this comment.
there should be at least one test with different InitContainerName that proves it effective
There was a problem hiding this comment.
sure, will update the test with different InitContainerName
There was a problem hiding this comment.
Hi @yonatankahana, sorry for super late response. I have included the initContainerName field and added new test case for different initContainerName value
yonatankahana
added
enhancement
kmdrn7
force-pushed
the
override-initcontainer-name
branch
from
68ad1da
to
1a8d92c
Compare
Feature Request
Description
I have several tools that use the container name as one of the filters/selectors. With the current k8tz injection strategy that uses the bootstrap initContainer, I have encountered several issues regarding the identical container naming between the bootstrap initContainer and the k8tz controller. To ensure that the filters/selector works as expected in other tools, I would like to add a feature that allows setting a custom container name for the bootstrap initContainer